feat: upgrade modules; add sdk directory #37
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull Request Overview
This pull request implements module upgrades and introduces a new SDK directory structure to support provider and wallet functionality.
- Module restructuring from
AddresstoAddressErasfor better era-specific address handling - Addition of SDK provider architecture with Kupo/Ogmios integration and type definitions
- New wallet utilities including seed-based wallet generation and script handling functionality
Reviewed Changes
Copilot reviewed 24 out of 29 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| packages/evolution/test/WalletFromSeed.test.ts | Test suite for wallet generation from seed phrases with different configurations |
| packages/evolution/test/Script.CML.test.ts | CBOR compatibility tests between Evolution SDK and Cardano Multiplatform Library |
| packages/evolution/src/sdk/wallet/utils.ts | Wallet utility functions for generating wallets from BIP39 seed phrases |
| packages/evolution/src/sdk/wallet/Wallet.ts | Duplicate wallet implementation (identical to utils.ts) |
| packages/evolution/src/sdk/provider/types.ts | Provider interface definitions and supporting types |
| packages/evolution/src/sdk/provider/internal/Ogmios.ts | Ogmios JSON-RPC protocol schemas and data transformations |
| packages/evolution/src/sdk/provider/internal/Kupo.ts | Kupo API schemas for UTxO and delegation data |
| packages/evolution/src/sdk/provider/internal/HttpUtils.ts | HTTP utility functions for GET/POST requests with schema validation |
| packages/evolution/src/sdk/provider/Provider.ts | Provider service interface and error handling |
| packages/evolution/src/sdk/provider/Kupmios.ts | Kupmios provider implementation combining Kupo and Ogmios |
| packages/evolution/src/sdk/UTxO.ts | UTxO data structures and utility functions |
| packages/evolution/src/sdk/Script.ts | User-facing script types and hash computation utilities |
| packages/evolution/src/sdk/Assets.ts | Asset manipulation and validation functions |
| packages/evolution/src/index.ts | Export path updates for module restructuring |
| packages/evolution/src/TransactionOutput.ts | Address import path updates |
| packages/evolution/src/TransactionBody.ts | Code formatting improvements |
| packages/evolution/src/ScriptHash.ts | Script hash computation implementation |
| packages/evolution/src/Script.ts | CBOR encoding/decoding function additions |
| packages/evolution/src/NetworkId.ts | Schema brand removal |
| packages/evolution/src/Bytes.ts | Parameter simplification in validation functions |
| packages/evolution/src/AddressStructure.ts | New unified address structure handling |
| packages/evolution/src/AddressEras.ts | Era-specific address type definitions |
| packages/evolution/src/AddressDetails.ts | Address import path updates |
| packages/evolution/package.json | Effect platform dependency addition |
Files not reviewed (1)
- pnpm-lock.yaml: Language not supported
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Comment on lines
+13
to
+83
| export type Wallet = { | ||
| address: string | ||
| rewardAddress: string | null | ||
| paymentKey: string | ||
| stakeKey: string | null | ||
| } | ||
|
|
||
| export function walletFromSeed( | ||
| seed: string, | ||
| options: { | ||
| password?: string | ||
| addressType?: "Base" | "Enterprise" | ||
| accountIndex?: number | ||
| network?: "Mainnet" | "Testnet" | "Custom" | ||
| } = {} | ||
| ): Wallet { | ||
| //Set default options | ||
| const { accountIndex = 0, addressType = "Base", network = "Mainnet" } = options | ||
|
|
||
| // Derive extended root from BIP39 entropy using our ed25519-bip32 (V2) implementation | ||
| const entropy = mnemonicToEntropy(seed, English) | ||
| const rootXPrv = Bip32PrivateKey.fromBip39Entropy(entropy, options?.password ?? "") | ||
|
|
||
| // Derive child keys using CIP-1852 indices | ||
| const paymentIndices = Bip32PrivateKey.CardanoPath.paymentIndices(accountIndex, 0) | ||
| const stakeIndices = Bip32PrivateKey.CardanoPath.stakeIndices(accountIndex, 0) | ||
| const paymentNode = Bip32PrivateKey.derive(rootXPrv, paymentIndices) | ||
| const stakeNode = Bip32PrivateKey.derive(rootXPrv, stakeIndices) | ||
|
|
||
| // Convert to standard PrivateKey (64 bytes: scalar+iv) | ||
| const paymentKey = Bip32PrivateKey.toPrivateKey(paymentNode) | ||
| const stakeKey = Bip32PrivateKey.toPrivateKey(stakeNode) | ||
|
|
||
| const paymentKeyHash = KeyHash.fromPrivateKey(paymentKey) | ||
| const stakeKeyHash = KeyHash.fromPrivateKey(stakeKey) | ||
|
|
||
| const networkId = network === "Mainnet" ? 1 : 0 | ||
|
|
||
| const address = | ||
| addressType === "Base" | ||
| ? Address.toBech32( | ||
| new BaseAddress.BaseAddress({ | ||
| networkId: NetworkId.make(networkId), | ||
| paymentCredential: paymentKeyHash, | ||
| stakeCredential: stakeKeyHash | ||
| }) | ||
| ) | ||
| : Address.toBech32( | ||
| new EnterpriseAddress.EnterpriseAddress({ | ||
| networkId: NetworkId.make(networkId), | ||
| paymentCredential: paymentKeyHash | ||
| }) | ||
| ) | ||
|
|
||
| const rewardAddress = | ||
| addressType === "Base" | ||
| ? Address.toBech32( | ||
| new RewardAccount.RewardAccount({ | ||
| networkId, | ||
| stakeCredential: stakeKeyHash | ||
| }) | ||
| ) | ||
| : null | ||
|
|
||
| return { | ||
| address, | ||
| rewardAddress, | ||
| paymentKey: PrivateKey.toBech32(paymentKey), | ||
| stakeKey: addressType === "Base" ? PrivateKey.toBech32(stakeKey) : null | ||
| } | ||
| } |
There was a problem hiding this comment.
This file is an exact duplicate of utils.ts. Consider removing this duplicate file and importing the function from utils.ts instead.
Suggested change
| export type Wallet = { | |
| address: string | |
| rewardAddress: string | null | |
| paymentKey: string | |
| stakeKey: string | null | |
| } | |
| export function walletFromSeed( | |
| seed: string, | |
| options: { | |
| password?: string | |
| addressType?: "Base" | "Enterprise" | |
| accountIndex?: number | |
| network?: "Mainnet" | "Testnet" | "Custom" | |
| } = {} | |
| ): Wallet { | |
| //Set default options | |
| const { accountIndex = 0, addressType = "Base", network = "Mainnet" } = options | |
| // Derive extended root from BIP39 entropy using our ed25519-bip32 (V2) implementation | |
| const entropy = mnemonicToEntropy(seed, English) | |
| const rootXPrv = Bip32PrivateKey.fromBip39Entropy(entropy, options?.password ?? "") | |
| // Derive child keys using CIP-1852 indices | |
| const paymentIndices = Bip32PrivateKey.CardanoPath.paymentIndices(accountIndex, 0) | |
| const stakeIndices = Bip32PrivateKey.CardanoPath.stakeIndices(accountIndex, 0) | |
| const paymentNode = Bip32PrivateKey.derive(rootXPrv, paymentIndices) | |
| const stakeNode = Bip32PrivateKey.derive(rootXPrv, stakeIndices) | |
| // Convert to standard PrivateKey (64 bytes: scalar+iv) | |
| const paymentKey = Bip32PrivateKey.toPrivateKey(paymentNode) | |
| const stakeKey = Bip32PrivateKey.toPrivateKey(stakeNode) | |
| const paymentKeyHash = KeyHash.fromPrivateKey(paymentKey) | |
| const stakeKeyHash = KeyHash.fromPrivateKey(stakeKey) | |
| const networkId = network === "Mainnet" ? 1 : 0 | |
| const address = | |
| addressType === "Base" | |
| ? Address.toBech32( | |
| new BaseAddress.BaseAddress({ | |
| networkId: NetworkId.make(networkId), | |
| paymentCredential: paymentKeyHash, | |
| stakeCredential: stakeKeyHash | |
| }) | |
| ) | |
| : Address.toBech32( | |
| new EnterpriseAddress.EnterpriseAddress({ | |
| networkId: NetworkId.make(networkId), | |
| paymentCredential: paymentKeyHash | |
| }) | |
| ) | |
| const rewardAddress = | |
| addressType === "Base" | |
| ? Address.toBech32( | |
| new RewardAccount.RewardAccount({ | |
| networkId, | |
| stakeCredential: stakeKeyHash | |
| }) | |
| ) | |
| : null | |
| return { | |
| address, | |
| rewardAddress, | |
| paymentKey: PrivateKey.toBech32(paymentKey), | |
| stakeKey: addressType === "Base" ? PrivateKey.toBech32(stakeKey) : null | |
| } | |
| } | |
| import { Wallet, walletFromSeed } from "../utils.js" |
Comment on lines
+197
to
+200
| export const getUtxos = (kupoUrl: string, headers?: { [key: string]: string }) => | ||
| Effect.fn("getUtxos")(function* ( | ||
| addressOrCredential: EnterpriseAddress.EnterpriseAddress | BaseAddress.BaseAddress | Credential.Credential | ||
| ) { |
There was a problem hiding this comment.
Missing import statements for Credential, KupmiosError, Script, Address, and applyDoubleCborEncoding types/functions that are referenced but not imported.
| }) | ||
| }).annotations({ identifier: "RedeemerSchema" }) | ||
|
|
||
| export const toOgmiosUTxOs = (utxos: Array<CoreType.UTxO> | undefined): Array<UTxO> => { |
There was a problem hiding this comment.
Missing import statement for CoreType which is referenced but not imported.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.